Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] device mismatch problems #267

Merged
merged 5 commits into from
Aug 13, 2024
Merged

[Fix] device mismatch problems #267

merged 5 commits into from
Aug 13, 2024

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Aug 13, 2024

Problem (Why?)

fixes #266

all parameters are not on the same device.

Solution (What/How?)

  • d_numerator device
  • others

Other changes (bug fixes, small refactors)

N/A

Notes

N/A

@kozistr kozistr added the bug Something isn't working label Aug 13, 2024
@kozistr kozistr self-assigned this Aug 13, 2024
@kozistr kozistr merged commit f4648b0 into main Aug 13, 2024
2 checks passed
@kozistr kozistr deleted the fix/prodigy-optimizer branch August 13, 2024 10:31
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.98%. Comparing base (58f923f) to head (fa94e7c).
Report is 131 commits behind head on main.

Files with missing lines Patch % Lines
pytorch_optimizer/optimizer/prodigy.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #267      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files           92       92              
  Lines         7007     7009       +2     
===========================================
+ Hits          7007     7008       +1     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prodigy optimizer cannot be resumed from checkpoint
1 participant